Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

amTimeAgo should use angular $timeout instead of setTimeout() #66

Closed
wants to merge 1 commit into from

Conversation

gregz67
Copy link

@gregz67 gregz67 commented Jul 24, 2014

For better angular integration, amTimeAgo should use $timeout instead of setTimeout() directly.

https://docs.angularjs.org/api/ng/service/$timeout

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2f1bb13 on gregz67:master into 83b4e33 on urish:master.

@urish
Copy link
Owner

urish commented Jul 28, 2014

Thank you for your contribution, it's greatly appreciated. However, using $timeout breaks e2e tests and also causes performance penalty (causes angular.js digest cycle for each update). See discussion in #35.

@gregz67
Copy link
Author

gregz67 commented Jul 28, 2014

I should have looked at past discussions. It looks like you have already explored this quite a bit. Seems like using $interval would be a good solution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants