Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test results #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

test results #2

wants to merge 4 commits into from

Conversation

Uriy13
Copy link

@Uriy13 Uriy13 commented Sep 12, 2019

To associate the change of the "Include" and "Exclude" fields with the corresponding fields in the config.json file, I added to the class constructor:

  1. read the data from the config.json file into an array "rules_array"
  2. add the cycle "for" for each field (in case the file "config.json" itself changes)
  3. in the body of the cycles, assign the values of the corresponding fields to the widgets plainTextEdit (field "Include") and plainTextEdit_2 (field "Exclude")

@urpylka
Copy link
Owner

urpylka commented Sep 13, 2019

Thanks for PR. I looked at your commits.

  1. And I ask you to squash your commits into one w the understandable message.
  2. Also if you participate in the test see at task 2. There I asked to make changes in config.json after changes in QT form and back. You made just second part. You need to use save button. You can see how that work in DeviceWindow.

Screenshot 2019-09-13 at 10 26 03

@urpylka urpylka added the enhancement New feature or request label Sep 13, 2019
@Uriy13
Copy link
Author

Uriy13 commented Sep 13, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants