convert to useCallback this reduces the function allocations by 1 for…

… each useQuery/useSubscription (#504)
urql-graphql · Jan 13, 2020 · 2fb68ee · 2fb68ee
1 parent e06098d
commit 2fb68ee
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/hooks/useQuery.ts b/src/hooks/useQuery.ts
@@ -41,8 +41,8 @@ export const useQuery = <T = any, V = object>(
   const request = useRequest(args.query, args.variables);
 
   // Create a new query-source from client.executeQuery
-  const makeQuery$ = useMemo(
-    () => (opts?: Partial<OperationContext>) => {
+  const makeQuery$ = useCallback(
+    (opts?: Partial<OperationContext>) => {
       return client.executeQuery(request, {
         requestPolicy: args.requestPolicy,
         pollInterval: args.pollInterval,

diff --git a/src/hooks/useSubscription.ts b/src/hooks/useSubscription.ts
@@ -47,8 +47,8 @@ export const useSubscription = <T = any, R = T, V = object>(
   const request = useRequest(args.query, args.variables);
 
   // Create a new subscription-source from client.executeSubscription
-  const makeSubscription$ = useMemo(
-    () => (opts?: Partial<OperationContext>) => {
+  const makeSubscription$ = useCallback(
+    (opts?: Partial<OperationContext>) => {
       return client.executeSubscription(request, { ...args.context, ...opts });
     },
     [client, request, args.context]