fix issue with ssr-exchange looping for reexecuted ops (#1944)

urql-graphql · Sep 11, 2021 · 63eec7e · 63eec7e
1 parent b90b6d5
commit 63eec7e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/flat-queens-refuse.md b/.changeset/flat-queens-refuse.md
@@ -0,0 +1,5 @@
+---
+'@urql/core': patch
+---
+
+Fix issue where the ssr-exchange would loop due to checking network-only revalidations
diff --git a/packages/core/src/exchanges/ssr.ts b/packages/core/src/exchanges/ssr.ts
@@ -80,6 +80,8 @@ const deserializeResult = (
   hasNext: result.hasNext,
 });
 
+const revalidated = new Set<number>();
+
 /** The ssrExchange can be created to capture data during SSR and also to rehydrate it on the client */
 export const ssrExchange = (params?: SSRExchangeParams): SSRExchange => {
   const staleWhileRevalidate = !!(params && params.staleWhileRevalidate);
@@ -128,8 +130,9 @@ export const ssrExchange = (params?: SSRExchangeParams): SSRExchange => {
       map(op => {
         const serialized = data[op.key]!;
         const result = deserializeResult(op, serialized);
-        if (staleWhileRevalidate) {
+        if (staleWhileRevalidate && !revalidated.has(op.key)) {
           result.stale = true;
+          revalidated.add(op.key);
           reexecuteOperation(client, op);
         }