fix(core): return a result in cache-only scenarios (#3459)

Co-authored-by: Phil Pluckthun <phil@kitten.sh>
urql-graphql · Dec 12, 2023 · d5d3c97 · d5d3c97
1 parent 0af6e54
commit d5d3c97
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/.changeset/three-pandas-invent.md b/.changeset/three-pandas-invent.md
@@ -0,0 +1,5 @@
+---
+'@urql/core': patch
+---
+
+Fix the default `cacheExchange` crashing on `cache-only` request policies with cache misses due to `undefined` results.
diff --git a/packages/core/src/exchanges/cache.ts b/packages/core/src/exchanges/cache.ts
@@ -9,6 +9,7 @@ import {
   addMetadata,
   collectTypenames,
   formatDocument,
+  makeResult,
 } from '../utils';
 
 type ResultCache = Map<number, OperationResult>;
@@ -79,7 +80,12 @@ export const cacheExchange: Exchange = ({ forward, client, dispatchDebug }) => {
               }),
         });
 
-        let result: OperationResult = cachedResult!;
+        let result: OperationResult =
+          cachedResult ||
+          makeResult(operation, {
+            data: null,
+          });
+
         if (process.env.NODE_ENV !== 'production') {
           result = {
             ...result,