fix(react): prioritise context.suspense (#3427)

urql-graphql · Nov 13, 2023 · f2c59c5 · f2c59c5
1 parent 3fe5b14
commit f2c59c5
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/.changeset/real-geese-grow.md b/.changeset/real-geese-grow.md
@@ -0,0 +1,6 @@
+---
+'urql': patch
+'@urql/preact': patch
+---
+
+Prioritise `context.suspense` and fallback to checking `client.suspense`
diff --git a/packages/preact-urql/src/hooks/useQuery.ts b/packages/preact-urql/src/hooks/useQuery.ts
@@ -212,7 +212,9 @@ function toSuspenseSource<T>(source: Source<T>): Source<T> {
 }
 
 const isSuspense = (client: Client, context?: Partial<OperationContext>) =>
-  client.suspense && (!context || context.suspense !== false);
+  context && context.suspense !== undefined
+    ? !!context.suspense
+    : client.suspense;
 
 const sources = new Map<number, Source<OperationResult>>();
 

diff --git a/packages/react-urql/src/hooks/useQuery.ts b/packages/react-urql/src/hooks/useQuery.ts
@@ -175,7 +175,9 @@ export type UseQueryResponse<
 > = [UseQueryState<Data, Variables>, UseQueryExecute];
 
 const isSuspense = (client: Client, context?: Partial<OperationContext>) =>
-  client.suspense && (!context || context.suspense !== false);
+  context && context.suspense !== undefined
+    ? !!context.suspense
+    : client.suspense;
 
 /** Hook to run a GraphQL query and get updated GraphQL results.
  *