Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(execute): Resolve promise context values #2806

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

YutaUra
Copy link
Contributor

@YutaUra YutaUra commented Nov 14, 2022

Resolves #2805

Summary

As per the Issue, I have fixed the exchange-execute to handle correctly when the context is a function that returns a Promise in exchange-execute.

Set of changes

  • @urql/exchange-execute

As far as I know, there should be no breaking changes.

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2022

🦋 Changeset detected

Latest commit: 756e118

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@urql/exchange-execute Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@kitten kitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!
I updated the changeset phrasing; let's get this merged 🙌

@kitten kitten changed the title Exchange execute/promise context feat(execute): Resolve promise context values Dec 1, 2022
@kitten kitten merged commit e86f50d into urql-graphql:main Dec 1, 2022
@github-actions github-actions bot mentioned this pull request Dec 1, 2022
@YutaUra YutaUra deleted the exchange-execute/promise-context branch December 1, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Allow exchange-execute to execute even if context returns a Promise Function
2 participants