feat(core): Reuse stringifyDocument and cached prints across @urql/core #2847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2787
Summary
This changes the internals of
@urql/core
to allow us to reusestringifyDocument
infetchOptions
and other places, to ensure that printing is memoised whenever possible — including forformatDocument
outputs.This means that we had to adjust our hashing slightly to account for the different outputs; that said, sanitisation will still be applied to
stringifyDocument
inputs. However, we will no longer reuseloc.source
strings when they haven't been printed by@urql/core
.Set of changes
phash
hashing function and create opaque type for clarityrequest.ts
'stringifyDocument
and hashingstringifyDocument
insubscriptionExchange
andfetchOptions
stringifyDocument
output