-
-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): move multipart/mixed
to end of accept headers
#3039
Conversation
multipart/mixed
when streaming directives are foundmultipart/mixed
to end of accept headers
Just noting based on discussions off GitHub; This isn't an issue with React Native per se, however, GraphQL Yoga seems to match the first transport method in This means that Yoga seems to trigger a multipart response, which is unsupported on React Native, even when this isn't stricly necessary, failing requests on RN entirely. |
Co-authored-by: Phil Pluckthun <phil@kitten.sh>
Is this part of a release? |
Ok, so that’s what that means. I was wondering if that corresponded to a release (like on |
Because we’re on |
After scouring the docs some more, seems like it due to still having It’s also worth mentioning that the package was actually |
@ericbf Yes, there is one: #3114 |
Summary
Follow up to #3007
In React-Native-Fetch streaming isn't supported meaning that the inclusion of
multipart/mixed
can lead to errors. We move it to the end of the Accept headers to avoid running into this bug. This was reported on Discord.Relates to facebook/react-native#27741