Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workspace): Fix sourcemaps for recent builds and versions #3053

Merged
merged 4 commits into from
Mar 15, 2023

Conversation

kitten
Copy link
Member

@kitten kitten commented Mar 15, 2023

Resolves #3048

Summary

Fixes sourcemap generation and marks a changeset for the affected packges.
Generally, it seems like @rollup/plugin-typescript mangled some source map paths for us, and stopped Rollup from also including source contents for the source mapped files.

Set of changes

  • Remove @rollup/plugin-typescript
  • Remove building of jsx/tsx from Rollup (since this was unused)
  • Enforce sourcemapExcludeSources: false option
  • Upgrade Rollup and related plugins

@kitten kitten requested a review from JoviDeCroock March 15, 2023 17:06
@kitten kitten changed the title Chore/fix sourcemaps chore(workspace): Fix sourcemaps for recent builds and versions Mar 15, 2023
@kitten kitten merged commit 35be3e5 into main Mar 15, 2023
@kitten kitten deleted the chore/fix-sourcemaps branch March 15, 2023 18:00
This was referenced Mar 15, 2023
@github-actions github-actions bot mentioned this pull request Mar 27, 2023
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to parse source errors
2 participants