Fix re-rendering when another component reuses the same query #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a change in the result
kitten
reviewed
Apr 28, 2023
Co-authored-by: Phil Pluckthun <phil@kitten.sh>
kitten
approved these changes
Apr 28, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When component A uses
useQueryand has already loaded a result and then component B mounts and uses the same query, it currently causes component A to re-render becauseoperationis not shallowly equal even though nothing about the result is changing.This is a performance issue because it causes unnecessary re-renders.
It also can cause an infinite render loop with lazily loaded components because it can trigger a state update further up the tree during the initial render of the lazily loaded component which makes React back out of the render (which happened in my application, although I've had trouble creating a minimal reproduction). This issue is resolved with this change in my application.
Set of changes
isShallowDifferentforoperationwhere it checks the operation key if theoperations are not equalCONTRIBUTING.md