fix(workspace): Fix sourcemap generation for “longer” bundles #3201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3182
Summary
It seems that during one of the past dependency upgrades sourcemap generation has slightly and subtly broken. For longer output bundles, the offset of sourcemaps would eventually be incorrect.
This was due to sourcemaps becoming broken in the
cleanupPlugin
, but since Rollup now provides an option for hoisted transitive imports, its use for JS output is now obsolete.I've also noticed that we're losing a bit of sourcemap fidelity with Sucrase, and since we're already parsing all files with Babel, we can safely move to a Babel TypeScript transformer.
Set of changes
hoistTransitiveImports
in Rollup output options