Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(svelte): Increase peer dependency range for Svelte 4 #3302

Merged
merged 4 commits into from
Jul 8, 2023

Conversation

ategen3rt
Copy link
Contributor

Resolves #3300

Summary

This allows the package to be installed in projects using svelte 4

Set of changes

Changed @urql/svelte
Added Svelte ^4.0.0 as a peer dependency (in addition to the ^3.0.0 that was already there.

@ptrxyz
Copy link

ptrxyz commented Jun 30, 2023

I am using Svelte 4 since it's release and things seem to be fine. However, there are some breaking changes in Svelte 4, but I can't tell if they are relevant for urql: https://svelte.dev/docs/v4-migration-guide#other-breaking-changes

Mostly they are about typing and components and some minor internal. Should not affect urql.

@kitten kitten changed the title Update package.json to support Svelte 4 chore(svelte): Increase peer dependency range for Svelte 4 Jul 1, 2023
@kitten
Copy link
Member

kitten commented Jul 1, 2023

Hiya,
I don't think the breaking changes affect us.

However, can you please upgrade the dev dependency for Svelte here, so we're actually using the newest against the range?

We also have an example here that can be bumped and tested, so if that's updated I'll have a look before merging: https://github.com/urql-graphql/urql/tree/main/examples/with-svelte

Lastly, every PR that changes code will need a changeset, as per the contributing guide: https://github.com/urql-graphql/urql/blob/main/CONTRIBUTING.md#how-do-i-document-a-change-for-the-changelog
This is to add changelog entries and to specify what version bump is required.
In this case, a patch entry with a description along the lines of "Updated peer dependency range to include support for Svelte 4" will be enough.

Happy to take either of these over, but please let me know.

@ategen3rt
Copy link
Contributor Author

I believe I did the tasks you mentioned correctly.

@frederikhors
Copy link
Contributor

Hi @ategen3rt and @ptrxyz, I saw you're using Svelte too.

I can be an accurate and fast tester of svelte@4 with urql but I'm stucked with #3304.

Can I ask for your help? Even just to figure out if I'm doing something wrong.

@kitten kitten merged commit caa029e into urql-graphql:main Jul 8, 2023
@github-actions github-actions bot mentioned this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Support Svelte@4.0.0
4 participants