fix(graphcache): Mutable links on InMemoryData store #3516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related PR: #3503
Summary
When
cache.resolve
returns a list of entity links, i.e. an array link, a user may be tempted to mutate this list before writing it back to the store.This can have unforeseen consequences if:
cache.link
then doesn't write to the same layercache.link
isn't called at allThis is because, unlike
cache.link
,cache.resolve
doesn't make a copy of links before returning them. This means that mutating a link array leads to direct modifications to the internal caching layer.Set of changes
ensureLink
before returning the links viacache.resolve
to copy them