-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue): Fix regression causing variables to not be reactive #3605
Conversation
|
Darn I missed that this doesn't have a changeset, do you mind adding one or should I? More info here or the bot comment above |
thanks, will do within another PR |
Pushed a changeset so I can add it to a release @yurks |
@JoviDeCroock just prepared the same, but too late) Thanks! |
Now it breaks down queries that don't have variables: error TS2345: Argument of type '{}' is not assignable to parameter of type 'Omit<UseQueryArgs<never, Exact<{ [key: string]: never; }>>, "query">'.
Property 'variables' is missing in type '{}' but required in type 'Omit<UseQueryArgs<never, Exact<{ [key: string]: never; }>>, "query">'.
29 const { data } = useFetchUserProvidersQuery({});
~~
node_modules/@urql/core/dist/urql-core-chunk.d.ts:848:5
848 variables: Variables;
~~~~~~~~~
'variables' is declared here. |
@negezor you are using codegen, and that's a typing issue in If you can try to use A bit more mess: based on your example you're using Looks like we are using the same stack, so I can recommend you temporary resolve this issue with |
@yurks It seems that the modification of |
Summary
Restore reactivity typings for
variables
input.This regression caused a number of issues using
graphql-code-generator
Set of changes
Reuse
MaybeRef
type for variables typing.