Remove wrapping request args in reactive to fix memory leak #3612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This eliminates the memory leak since reactive always assigned new
watchEffects
to the static request object.Resolves: #3507 (comment)
Memory leak appeared in this PR #1151
Set of changes
args
inreactive
inuseQuery.ts
anduseSubscription.ts
This change is not breaking, since we still do
unref
as before #1151 PR.