chore(SSRExchange): Remove 2nd data serialization #3643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unnecessary to set it a 2nd time.
The preceding code is
```
const serialized: SerializedResult = {
data: JSON.stringify(result.data),
hasNext: result.hasNext,
};
```
which has initialized `serialized.data` with the very same value that the removed code is setting.
|
ccouzens
changed the title
ccouzens
changed the title
|
Closing since this is a duplicate in intention of #3632, with prior discussion there. Also please follow the contributing guidelines next time, if you do choose to contribute again ❤️ They contain notes on changesets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unnecessary to set it a 2nd time.
The preceding code is
which has initialized
serialized.datawith the very same value that the removed code is setting.Summary
Set of changes