New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) - apply minimum of 90%coverage #398

Closed

JoviDeCroock wants to merge 1 commit into master from chore/updateCodecov

Collaborator

JoviDeCroock commented Aug 20, 2019

I noticed that codecov is a bit too strict, we want to stay above 90% a drop of 0.3 shouldn't make a PR fail.

Related to: #397


          (chore) - apply minimum of 90%coverage

4f12920

JoviDeCroock requested a review from kitten

August 20, 2019 12:18

mxstbr suggested changes

View reviewed changes

Contributor

mxstbr left a comment

I actually think that #397 should fail. We have not added any tests, so CI is correctly indicating that they are missing and need to be added.

JoviDeCroock closed this

JoviDeCroock deleted the chore/updateCodecov branch

August 20, 2019 13:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet