Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert to useCallback this reduces the function allocations by 1 for… #504

Merged
merged 1 commit into from
Jan 13, 2020
Merged

convert to useCallback this reduces the function allocations by 1 for… #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/hooks/useQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ export const useQuery = <T = any, V = object>(
const request = useRequest(args.query, args.variables);

// Create a new query-source from client.executeQuery
const makeQuery$ = useMemo(
() => (opts?: Partial<OperationContext>) => {
const makeQuery$ = useCallback(
(opts?: Partial<OperationContext>) => {
return client.executeQuery(request, {
requestPolicy: args.requestPolicy,
pollInterval: args.pollInterval,
Expand Down
4 changes: 2 additions & 2 deletions src/hooks/useSubscription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ export const useSubscription = <T = any, R = T, V = object>(
const request = useRequest(args.query, args.variables);

// Create a new subscription-source from client.executeSubscription
const makeSubscription$ = useMemo(
() => (opts?: Partial<OperationContext>) => {
const makeSubscription$ = useCallback(
(opts?: Partial<OperationContext>) => {
return client.executeSubscription(request, { ...args.context, ...opts });
},
[client, request, args.context]
Expand Down