Make sure Context sets required fields. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on getting the [Go HTTP Routing Benchmark](https://github.com/julienschmidt/go-http-routing-benchmark) to compile / run, an issue with the `bear` package was being observed. Specifically, both the `http.ResponseWriter` and `*http.Request` sent to the HandleFunc were set to `nil`. Upon digging in to the codebase it was found that these two `Context{}` structs were being created incorrectly. It may be worth mentioning that I am not a user of `bear`, so I wouldn't be able to determine whether these are the right changes to be making. This should probably also have a regression test written for it. Please let me know if any thing else is needed to merge this changeset.
|
Hi @theckman! Wow, you're totally right. I guess I haven't been using the root handler or the wildcard handlers with the signature that would have exposed this. Thanks for fixing it; well spotted! |
afshin
approved these changes
Sep 25, 2016
afshin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on getting the Go HTTP Routing Benchmark
to compile / run, an issue with the
bearpackage was being observed.Specifically, both the
http.ResponseWriterand*http.Requestsentto the HandleFunc were set to
nil. Upon digging in to the codebaseit was found that these two
Context{}structs were being createdincorrectly.
It may be worth mentioning that I am not a user of
bear, so I wouldn'tbe able to determine whether these are the right changes to be making.
This should probably also have a regression test written for it.
Please let me know if any thing else is needed to merge this changeset.