Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version command #18

Closed
ursuscamp opened this issue Nov 8, 2023 · 6 comments · Fixed by #28
Closed

Add version command #18

ursuscamp opened this issue Nov 8, 2023 · 6 comments · Fixed by #28
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ursuscamp
Copy link
Owner

Add a version command to the indexer's CLI
@ursuscamp ursuscamp added enhancement New feature or request good first issue Good for newcomers labels Nov 8, 2023
@HakanVardarr
Copy link
Contributor

Do you want the version to be hard coded? Or do you have an idea that I can work?

@ursuscamp
Copy link
Owner Author

You can use env!("CARGO_PKG_VERSION") to get the version from the build system. That's the same thing the stats page gets it.

@HakanVardarr
Copy link
Contributor

Oh ok thanks I will work on that.

@HakanVardarr
Copy link
Contributor

Should I write version command as a subcommand or a option?

@ursuscamp
Copy link
Owner Author

Subcommand

ursuscamp pushed a commit that referenced this issue Nov 13, 2023
@HakanVardarr @ursuscamp
Version subcomand #18
09d6da4
ursuscamp pushed a commit that referenced this issue Nov 13, 2023
@HakanVardarr @ursuscamp
feat: Version subcomand #18
429eae4
@ursuscamp ursuscamp linked a pull request Nov 13, 2023 that will close this issue
Version subcomand #18 #28
Merged
@ursuscamp
Copy link
Owner Author

Thanks, @HakanVardarr. Merged #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version subcomand #18
2 participants
@ursuscamp @HakanVardarr