Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored db module to sub-modules #25

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Refactored db module to sub-modules #25

merged 2 commits into from
Nov 12, 2023

Conversation

HakanVardarr
Copy link
Contributor

I refactored the db module, if there are parts you don't like, I can rework on them.

ursuscamp
ursuscamp requested changes Nov 12, 2023
View reviewed changes
Copy link
Owner

@ursuscamp ursuscamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I really appreciate the contribution. Just a couple of minor suggestions and it is good to go.

Thanks.

nomen/src/db/blockchain_index.rs Outdated
pub blockheight: usize,
pub txheight: usize,
pub vout: usize,
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

nomen/src/db/index.rs Outdated Show resolved Hide resolved
nomen/src/db/name_details.rs Outdated Show resolved Hide resolved
@ursuscamp ursuscamp merged commit 18d4fb8 into ursuscamp:master Nov 12, 2023
4 checks passed
ursuscamp pushed a commit that referenced this pull request Nov 12, 2023
@HakanVardarr @ursuscamp
refactor: Refactored db module to sub-modules (#25)
6126258
ursuscamp pushed a commit that referenced this pull request Nov 12, 2023
@HakanVardarr @ursuscamp
refactor: db module to sub-modules (#25)
94a91d0
ursuscamp pushed a commit that referenced this pull request Nov 12, 2023
@HakanVardarr @ursuscamp
refactor: Refactored db module to sub-modules (#25)
bc31673
@ursuscamp ursuscamp mentioned this pull request Nov 12, 2023
Closed
@HakanVardarr HakanVardarr deleted the refactor-db branch November 13, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ursuscamp ursuscamp ursuscamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HakanVardarr @ursuscamp