Merge remote-tracking branch 'upstream/main' into fix-3648

urugator · Oct 29, 2023 · 452832f · 452832f
2 parents d33d2c7 + 5063c38
commit 452832f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/hip-bulldogs-act.md b/.changeset/hip-bulldogs-act.md
@@ -0,0 +1,5 @@
+---
+"mobx-react": patch
+---
+
+Fixed premature disposal of class component observers.
diff --git a/packages/mobx-react/src/observerClass.ts b/packages/mobx-react/src/observerClass.ts
@@ -133,7 +133,7 @@ export function makeClassComponentObserver(
         admin.mounted = true
 
         // Component instance committed, prevent reaction disposal.
-        observerFinalizationRegistry.unregister(admin)
+        observerFinalizationRegistry.unregister(this)
 
         // We don't set forceUpdate before mount because it requires a reference to `this`,
         // therefore `this` could NOT be garbage collected before mount,