Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert functions to use httr2 #47

Open
Aariq opened this issue Nov 20, 2024 · 1 comment · May be fixed by #82
Open

Convert functions to use httr2 #47

Aariq opened this issue Nov 20, 2024 · 1 comment · May be fixed by #82
Assignees
Labels

Comments

@Aariq
Copy link
Collaborator

Aariq commented Nov 20, 2024

Remove httr as a dependency and eventually also replace curl if possible.

Major benefits to using httr2 for everything:

@Aariq Aariq self-assigned this Nov 20, 2024
@Aariq
Copy link
Collaborator Author

Aariq commented Dec 10, 2024

Big chunk of this done with #49
Still left:

  • a few functions in npn_geoserver.R use httr
  • the check_service() utilities use httr
  • a couple instances of download.file()
  • all the data download functions which use curl

@Aariq Aariq added the refactor label Jan 7, 2025
@Aariq Aariq added this to the rOpenSci submission prep milestone Jan 7, 2025
@Aariq Aariq linked a pull request Jan 8, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant