Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom window for phenometrics #83

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Custom window for phenometrics #83

wants to merge 22 commits into from

Conversation

Aariq
Copy link
Collaborator

@Aariq Aariq commented Jan 27, 2025

Adds a year_start and year_end argument, with some input validation, to npn_get_data_by_year() and (eventually) functions that call npn_get_data_by_year()

Still to do:

@Aariq Aariq linked an issue Feb 4, 2025 that may be closed by this pull request
@Aariq
Copy link
Collaborator Author

Aariq commented Feb 5, 2025

This is ready for review I think. I removed the code that added start_date and end_date columns because I realized it isn't appropriate for all functions that call npn_get_data() (e.g. npn_download_status_data() results already have a column for observation date). I'll open an issue describing where specifically this may be needed as it might be more complicated to handle this.

@Aariq Aariq marked this pull request as ready for review February 5, 2025 18:10
@Aariq
Copy link
Collaborator Author

Aariq commented Feb 5, 2025

This is ready for review I think. I removed the code that added start_date and end_date columns because I realized it isn't appropriate for all functions that call npn_get_data() (e.g. npn_download_status_data() results already have a column for observation date). I'll open an issue describing where specifically this may be needed as it might be more complicated to handle this.

@Aariq Aariq changed the title [WIP] Custom window for phenometrics Custom window for phenometrics Feb 5, 2025
@Aariq Aariq requested a review from jeffswitzer February 5, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom window for phenometrics
1 participant