feat(usabilla): add support for configuring client #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuisman
approved these changes
Oct 5, 2017
| this.accessKey = accessKey; | ||
| this.secretKey = secretKey; | ||
| this.host = host; | ||
| this.host = 'data.usabilla.com'; |
There was a problem hiding this comment.
yep, this signature factory is bound to this domain
There was a problem hiding this comment.
Cool! Yes that is what I thought, that is why I moved it there!
|
@shuisman you mean to encourage the use of https, right? |
spirosikmd
force-pushed
the
client-configuration
branch
from
717f6ba
to
ee282ff
Compare
spirosikmd
changed the title
spirosikmd
force-pushed
the
client-configuration
branch
from
54c2358
to
16ef5f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35