Reuse connections when making API calls #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the Python requests module will create a new session object each time it is called. This means that each requests.get call has a separate connection pool and cannot reuse connections created by previous requests. Here we create a class variable with a requests session, which is used for all instances of the APIClient class.
|
Reusing the connection is a nice improvement indeed. There's no real way to add tests for this, is there? |
|
We could maybe test to make sure that that the socket module's connect method is only called once per request, but I don't think it's worth it. The code works whether or not it reuses connections, and we already have tests for it working. This is just a performance optimisation. |
gwkunze
approved these changes
May 14, 2018
tzengerink
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the Python requests module will create a new session object each time it is called. This means that each requests.get call has a separate connection pool and cannot reuse connections created by previous requests.
Here we create a class variable with a requests session, which is used for all instances of the APIClient class.
This does mean that sessions will now be shared between all APIClient objects in a process, even if they use different credentials. I do not believe this is a problem because requests are independently authenticated, but I would appreciate a review from someone more familiar with this code anyway.