Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote-2823: Know your voting rights French update #1003

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Vote-2823: Know your voting rights French update #1003

merged 1 commit into from
Sep 24, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Sep 24, 2024 •
edited by rayestrada
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2823

Description

Adding string translation for Know your voting rights

Deployment and testing

Post-deploy steps

  1. run lando retune

QA/Testing instructions

  1. Verify translation is added

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada marked this pull request as ready for review September 24, 2024 21:31
@rayestrada rayestrada merged commit 1cf1446 into dev Sep 24, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-2823-fr-string-update branch September 25, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayestrada rayestrada rayestrada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clmedders @rayestrada