Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-2909: Regression fix for link styles #1007

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Sep 25, 2024

Jira ticket

Vote-2909

Description

Addressing a bug that was added after the NVRF link hover styles were added. This will fix the issues with links styled as buttons losing the text color after being visited

Screen.Recording.2024-09-24.at.3.51.54.PM.mov

Deployment and testing

Post-deploy steps

  1. cd into the votegov theme and run npm run build and clear cache

QA/Testing instructions

  1. Spot check site to ensure no other links have regression added
  2. visit the log in page and verify that the button has been fixed
  3. visit the NVRF form and verify that the original fix is still applied see this pr for reference

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders requested review from SamiraMSadat and rayestrada and removed request for SamiraMSadat September 26, 2024 15:58
@clmedders clmedders marked this pull request as ready for review September 26, 2024 15:58
@rayestrada rayestrada merged commit 07b5101 into dev Sep 26, 2024
3 checks passed
@rayestrada rayestrada deleted the bug/vote-2909-link-style branch December 3, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants