Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2903 incorporate latest data structure changes from nvrf #1010

Merged
merged 2 commits into from
Oct 7, 2024
Merged

VOTE-2903 incorporate latest data structure changes from nvrf #1010

merged 2 commits into from
Oct 7, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Sep 26, 2024 •
edited
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2903

Description

Update NVRF to latest v0.18.0

Deployment and testing

Post-deploy steps

  1. run npm i and npm run build in vote_nvrf module directory
  2. lando drush cr

QA/Testing instructions

  1. visit the NVRF page in English and Spanish and confirm that you are able to complete the form to completion.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada marked this pull request as ready for review October 7, 2024 15:55
SamiraMSadat
SamiraMSadat approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@SamiraMSadat SamiraMSadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed all fields in English and Spanish

@SamiraMSadat SamiraMSadat merged commit a296224 into dev Oct 7, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2903-nvrf-updates branch December 3, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamiraMSadat SamiraMSadat SamiraMSadat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @SamiraMSadat