Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-2843: Update to spacing for search box #1013

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Sep 30, 2024

Jira ticket

Vote-2843

Description

Addressing bug with spacing not staying consistent with the search box when toggling on the text size button from the a11y bar

Before:

Vote.2843.Screen.mov

After:

Screen.Recording.2024-09-30.at.9.59.10.AM.mov

Deployment and testing

Post-deploy steps

  1. cd into the votegov theme and run npm run build to compile the assets

QA/Testing instructions

  1. toggle the larger text button on the a11y bard and verify that the vertical space stays consistant as the text size grows

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders requested a review from mlloydbixal October 1, 2024 14:39
@clmedders clmedders marked this pull request as ready for review October 1, 2024 14:39
@mlloydbixal mlloydbixal merged commit 3e70eb0 into dev Oct 3, 2024
2 checks passed
@rayestrada rayestrada deleted the bug/vote-2843-seachbox-top-margin branch December 3, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants