Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2634: Hard coded string content Chinese Simplified #1018

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

mlloydbixal
Copy link
Contributor

Jira ticket

VOTE-2634

Description

Adds the hardcoded strings for Chinese Simplified.

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. Compare string changes to the google doc

*note that the doc is highlighted in red for the ones that can't be done here AND we are not adding the military/overseas strings since we don't have the translation

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@SamiraMSadat SamiraMSadat merged commit b9ff9d0 into dev Oct 4, 2024
2 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2643/chinese-simplified-strings branch December 3, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants