Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2885 configure state mail registration section #1039

Merged
merged 4 commits into from
Oct 9, 2024
Merged

VOTE-2885 configure state mail registration section #1039

merged 4 commits into from
Oct 9, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Oct 8, 2024 •
edited
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2885

Description

  1. Add ability to hide state display content subfields from the form
  2. Configure state mail registration section

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/block/add/state_display_content and confirm that the 'Link text' subfield is hidden for Registration Intro field.
  2. visit http://vote-gov.lndo.site/register/washington and confirm the content for mail and NVRF displays
  3. visit http://vote-gov.lndo.site/register/wyoming and confirm the content for mail displays but not NVRF

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada mentioned this pull request Oct 8, 2024
Closed
10 tasks
@rayestrada rayestrada requested a review from clmedders October 8, 2024 23:54
@clmedders clmedders merged commit 570529c into state-enhancement Oct 9, 2024
2 checks passed
@clmedders clmedders deleted the feature/VOTE-2885-mail-section-re branch October 9, 2024 13:17
rayestrada added a commit that referenced this pull request Oct 29, 2024
@rayestrada
Squashed commit of the following: state-enhancement
1b4ccf5 
commit 330cd03
Author: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
Date:   Wed Oct 23 10:25:18 2024 -0600

    VOTE-2972 additional check reg box (#1060)

commit 88cf019
Author: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
Date:   Wed Oct 23 07:11:09 2024 -0600

    VOTE-3020 Reenable the NVRF details field in the state override content (#1065)

commit f83098b
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Tue Oct 22 11:31:43 2024 -0400

    Vote-2958: No mail registration block (#1058)

    * update to twig template

    * Update to config

    * updated no mail to have nvrf render if checked

    * VOTE-2958 Fix the mail deadline replacement

    * VOTE-2958 Use state name var with capital letter

    ---------

    Co-authored-by: SamiraMSadat <samira.sadat@gsa.gov>

commit a110d94
Author: Mandy Lloyd <amanda.lloyd@gsa.gov>
Date:   Fri Oct 18 20:18:59 2024 -0400

    VOTE-2880/2881: Configure and style call out box (#1047)

commit f1a9963
Merge: 284b521 fbc4145
Author: Ray Estrada <raymond.estrada@gsa.gov>
Date:   Fri Oct 18 17:16:15 2024 -0700

    Merge remote-tracking branch 'origin/dev' into state-enhancement

commit fbc4145
Merge: 218a142 bb38a76
Author: Ray Estrada <raymond.estrada@gsa.gov>
Date:   Fri Oct 18 11:29:46 2024 -0700

    Merge pull request #1052 from usagov/stage

    VOTE-2993 HOTFIX release merge to DEV

commit 284b521
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Fri Oct 18 10:41:03 2024 -0400

    Vote-2959: Deprecate Registration Intro Field (#1056)

    * Update to twig templete

    * Update to config

    ---------

    Co-authored-by: SamiraMSadat <samira.sadat@gsa.gov>

commit 939de51
Author: SamiraMSadat <samira.sadat@gsa.gov>
Date:   Fri Oct 18 08:39:20 2024 -0600

    HOTFIX - Restore registration type variables

commit b3a5941
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Thu Oct 17 15:36:31 2024 -0400

    Vote-2957: No Online Registration (#1054)

    * add placeholder for no online reg

    * Updating twig template

    * Update to config for  new field

commit 218a142
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Thu Oct 17 12:36:54 2024 -0400

    Vote-2979: Chinese Simplified String Updates (#1053)

    * zh-hans string updates

    * VOTE-2979 Fix titles

    ---------

    Co-authored-by: SamiraMSadat <samira.sadat@gsa.gov>

commit bb38a76
Author: Ray Estrada <raymond.estrada@gsa.gov>
Date:   Wed Oct 16 07:10:40 2024 -0700

    VOTE-2993 update nvrf data asset directory location
    Update NVRF to v0.18.2

commit 8b38dcc
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Tue Oct 15 16:02:50 2024 -0400

    Vote-2990: Link Style Update to Emergency Banner (#1046)

commit 68f40b9
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Tue Oct 15 13:41:56 2024 -0400

    Vote-2978: Config for Override NVRF field (#1045)

    * Updating twing file for some clean up

    * Update to config for new NVRF override field

commit 78826db
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Oct 14 09:32:49 2024 -0400

    Vote-2977: Bump @uswds/uswds from 3.8.2 to 3.9.0

commit 4975b65
Merge: e40282c 3a41fba
Author: Ray Estrada <raymond.estrada@gsa.gov>
Date:   Thu Oct 10 16:10:13 2024 -0700

    Merge pull request #1043 from usagov/dev

    Sprint 69 HOTFIX Release to Stage

commit 3a41fba
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Thu Oct 10 17:33:28 2024 -0400

    Vote-2826: Migrate Cypress Backend Test to Page Objects (#1041)

    * init work

    * saving work - footer menu

    * adding data-test attribute to twig file

    * update to cypress tests

commit af7a011
Author: Mandy Lloyd <amanda.lloyd@gsa.gov>
Date:   Thu Oct 10 16:56:24 2024 -0400

    VOTE-2965: Fix body text wrap (#1038)

commit d0016aa
Author: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
Date:   Thu Oct 10 14:24:16 2024 -0600

    Update NVRF to v0.18.1 (#1042)

commit 9a3d932
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Thu Oct 10 15:39:15 2024 -0400

    Vote-2887: Config for Outside US Info Card (#1040)

commit 2acf5df
Author: Daniel Crowder <daniel.crowder@gsa.gov>
Date:   Wed Oct 9 17:51:24 2024 -0400

    VOTE-2462 & VOTE-2460: Document steps for drupal core and module updates. Update list of custom m… (#1031)

commit 570529c
Author: Ray Estrada <raymond.estrada@gsa.gov>
Date:   Wed Oct 9 06:17:48 2024 -0700

    VOTE-2885 configure state mail registration section (#1039)

commit 926fd75
Author: Mandy Lloyd <amanda.lloyd@gsa.gov>
Date:   Tue Oct 8 13:49:08 2024 -0400

    VOTE-2888: Configure in-page navigation (#1026)

    * VOTE-2888: Configure in-page nav on stage page

    * make aside block empty on not needed template

commit 5a0150f
Merge: 87873bb 18ab113
Author: Ray Estrada <raymond.estrada@gsa.gov>
Date:   Tue Oct 8 10:26:17 2024 -0700

    Merge remote-tracking branch 'origin/dev' into state-enhancement

commit 87873bb
Author: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
Date:   Mon Oct 7 14:09:23 2024 -0600

    VOTE-2884 Configure the display of online reg card (#1035)

commit b103f80
Author: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
Date:   Fri Oct 4 12:55:36 2024 -0600

    VOTE-2883 Election date display (#1025)

commit d821f0a
Author: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
Date:   Fri Oct 4 09:54:31 2024 -0600

    VOTE-2886 state enhancement in person (#1028)

commit f9e5279
Author: Ray Estrada <raymond.estrada@gsa.gov>
Date:   Wed Oct 2 12:50:18 2024 -0700

    VOTE-2882 refine fallbacks for the state display content (#1024)

commit 9d9b28b
Author: Ray Estrada <raymond.estrada@gsa.gov>
Date:   Wed Oct 2 10:46:49 2024 -0700

    VOTE-2882 display intro or not needed state content (#1023)

commit bdeba7f
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Tue Oct 1 11:18:27 2024 -0400

    Vote-2878: add new Info Card Component (#1014)
rayestrada added a commit that referenced this pull request Oct 29, 2024
@rayestrada
Squashed commit of the following: state-enhancement
b701b09 
commit cfadc1a
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Tue Oct 29 16:19:44 2024 -0400

    Vote-3051: not needed template update (#1081)

    * Vote-3051: update to not needed template

    * Vote-3051: adding update date to tempalte

commit 0332132
Author: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
Date:   Tue Oct 29 09:09:20 2024 -0600

    VOTE- 3024 fix election date styling (#1067)

commit 52b41ba
Author: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
Date:   Tue Oct 29 08:52:33 2024 -0600

    VOTE-3036 Replicate markup changes for in page nav to voter guide page (#1070)

commit 40daefa
Author: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
Date:   Tue Oct 29 07:38:01 2024 -0600

    VOTE-3006 empty link text bug (#1066)

commit 330cd03
Author: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
Date:   Wed Oct 23 10:25:18 2024 -0600

    VOTE-2972 additional check reg box (#1060)

commit 88cf019
Author: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
Date:   Wed Oct 23 07:11:09 2024 -0600

    VOTE-3020 Reenable the NVRF details field in the state override content (#1065)

commit f83098b
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Tue Oct 22 11:31:43 2024 -0400

    Vote-2958: No mail registration block (#1058)

    * update to twig template

    * Update to config

    * updated no mail to have nvrf render if checked

    * VOTE-2958 Fix the mail deadline replacement

    * VOTE-2958 Use state name var with capital letter

    ---------

    Co-authored-by: SamiraMSadat <samira.sadat@gsa.gov>

commit a110d94
Author: Mandy Lloyd <amanda.lloyd@gsa.gov>
Date:   Fri Oct 18 20:18:59 2024 -0400

    VOTE-2880/2881: Configure and style call out box (#1047)

commit f1a9963
Merge: 284b521 fbc4145
Author: Ray Estrada <raymond.estrada@gsa.gov>
Date:   Fri Oct 18 17:16:15 2024 -0700

    Merge remote-tracking branch 'origin/dev' into state-enhancement

commit fbc4145
Merge: 218a142 bb38a76
Author: Ray Estrada <raymond.estrada@gsa.gov>
Date:   Fri Oct 18 11:29:46 2024 -0700

    Merge pull request #1052 from usagov/stage

    VOTE-2993 HOTFIX release merge to DEV

commit 284b521
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Fri Oct 18 10:41:03 2024 -0400

    Vote-2959: Deprecate Registration Intro Field (#1056)

    * Update to twig templete

    * Update to config

    ---------

    Co-authored-by: SamiraMSadat <samira.sadat@gsa.gov>

commit 939de51
Author: SamiraMSadat <samira.sadat@gsa.gov>
Date:   Fri Oct 18 08:39:20 2024 -0600

    HOTFIX - Restore registration type variables

commit b3a5941
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Thu Oct 17 15:36:31 2024 -0400

    Vote-2957: No Online Registration (#1054)

    * add placeholder for no online reg

    * Updating twig template

    * Update to config for  new field

commit 218a142
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Thu Oct 17 12:36:54 2024 -0400

    Vote-2979: Chinese Simplified String Updates (#1053)

    * zh-hans string updates

    * VOTE-2979 Fix titles

    ---------

    Co-authored-by: SamiraMSadat <samira.sadat@gsa.gov>

commit bb38a76
Author: Ray Estrada <raymond.estrada@gsa.gov>
Date:   Wed Oct 16 07:10:40 2024 -0700

    VOTE-2993 update nvrf data asset directory location
    Update NVRF to v0.18.2

commit 8b38dcc
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Tue Oct 15 16:02:50 2024 -0400

    Vote-2990: Link Style Update to Emergency Banner (#1046)

commit 68f40b9
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Tue Oct 15 13:41:56 2024 -0400

    Vote-2978: Config for Override NVRF field (#1045)

    * Updating twing file for some clean up

    * Update to config for new NVRF override field

commit 78826db
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Oct 14 09:32:49 2024 -0400

    Vote-2977: Bump @uswds/uswds from 3.8.2 to 3.9.0

commit 4975b65
Merge: e40282c 3a41fba
Author: Ray Estrada <raymond.estrada@gsa.gov>
Date:   Thu Oct 10 16:10:13 2024 -0700

    Merge pull request #1043 from usagov/dev

    Sprint 69 HOTFIX Release to Stage

commit 3a41fba
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Thu Oct 10 17:33:28 2024 -0400

    Vote-2826: Migrate Cypress Backend Test to Page Objects (#1041)

    * init work

    * saving work - footer menu

    * adding data-test attribute to twig file

    * update to cypress tests

commit af7a011
Author: Mandy Lloyd <amanda.lloyd@gsa.gov>
Date:   Thu Oct 10 16:56:24 2024 -0400

    VOTE-2965: Fix body text wrap (#1038)

commit d0016aa
Author: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
Date:   Thu Oct 10 14:24:16 2024 -0600

    Update NVRF to v0.18.1 (#1042)

commit 9a3d932
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Thu Oct 10 15:39:15 2024 -0400

    Vote-2887: Config for Outside US Info Card (#1040)

commit 2acf5df
Author: Daniel Crowder <daniel.crowder@gsa.gov>
Date:   Wed Oct 9 17:51:24 2024 -0400

    VOTE-2462 & VOTE-2460: Document steps for drupal core and module updates. Update list of custom m… (#1031)

commit 570529c
Author: Ray Estrada <raymond.estrada@gsa.gov>
Date:   Wed Oct 9 06:17:48 2024 -0700

    VOTE-2885 configure state mail registration section (#1039)

commit 926fd75
Author: Mandy Lloyd <amanda.lloyd@gsa.gov>
Date:   Tue Oct 8 13:49:08 2024 -0400

    VOTE-2888: Configure in-page navigation (#1026)

    * VOTE-2888: Configure in-page nav on stage page

    * make aside block empty on not needed template

commit 5a0150f
Merge: 87873bb 18ab113
Author: Ray Estrada <raymond.estrada@gsa.gov>
Date:   Tue Oct 8 10:26:17 2024 -0700

    Merge remote-tracking branch 'origin/dev' into state-enhancement

commit 87873bb
Author: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
Date:   Mon Oct 7 14:09:23 2024 -0600

    VOTE-2884 Configure the display of online reg card (#1035)

commit b103f80
Author: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
Date:   Fri Oct 4 12:55:36 2024 -0600

    VOTE-2883 Election date display (#1025)

commit d821f0a
Author: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
Date:   Fri Oct 4 09:54:31 2024 -0600

    VOTE-2886 state enhancement in person (#1028)

commit f9e5279
Author: Ray Estrada <raymond.estrada@gsa.gov>
Date:   Wed Oct 2 12:50:18 2024 -0700

    VOTE-2882 refine fallbacks for the state display content (#1024)

commit 9d9b28b
Author: Ray Estrada <raymond.estrada@gsa.gov>
Date:   Wed Oct 2 10:46:49 2024 -0700

    VOTE-2882 display intro or not needed state content (#1023)

commit bdeba7f
Author: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Date:   Tue Oct 1 11:18:27 2024 -0400

    Vote-2878: add new Info Card Component (#1014)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clmedders clmedders clmedders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @clmedders