Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2993 nvrf data directory update #1050

Merged
merged 1 commit into from
Oct 16, 2024
Merged

VOTE-2993 nvrf data directory update #1050

merged 1 commit into from
Oct 16, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Oct 16, 2024 •
edited
Loading

Update NVRF to v0.18.2

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2993

Description

Update NVRF to v0.18.2 and change location of nvrf data directory

Deployment and testing

Post-deploy steps

  1. cd into vote_nvrf and run npm i
  2. run lando retune

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/es and confirm you can access the spanish homepage.
  2. visit http://vote-gov.lndo.site/es/registrar/idaho/llenador-de-formulario-por-correo-postal and test the NVRF in Spanish
  3. visit http://vote-gov.lndo.site/register/idaho/mail-in-form-filler and test the NVRF in English.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada marked this pull request as ready for review October 16, 2024 14:56
daniel-crowder
daniel-crowder approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@daniel-crowder daniel-crowder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally

@rayestrada rayestrada merged commit bb38a76 into stage Oct 16, 2024
2 checks passed
@rayestrada rayestrada deleted the bug/VOTE-2993-nvrf-data-directory branch December 3, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-crowder daniel-crowder daniel-crowder approved these changes

@SamiraMSadat SamiraMSadat Awaiting requested review from SamiraMSadat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @daniel-crowder