Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-3037 Hide untranslated state links in registration tool #1073

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Oct 24, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-3037

Description

Hide state links in registration tool when the pages are unpublished or untranslated.

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/node/77/translations and add a translation for Japanese and confirm that the state list does not display on the page when you view it
  2. visit http://vote-gov.lndo.site/node/8/translations and add a translation for Japanese and then visit http://vote-gov.lndo.site/ja/register and confirm only the link for Alaska displays in the list

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada marked this pull request as ready for review October 24, 2024 23:37
@SamiraMSadat SamiraMSadat merged commit 54c769b into dev Oct 28, 2024
2 checks passed
@rayestrada rayestrada deleted the bug/VOTE-3037-reg-tool-links branch December 3, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants