Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2961 Add help text for state display content fields #1101

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Nov 13, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2961

Description

Add helptext features to state page enhancement fields and data types. Add missing fields for:

  • deadline labels
  • toggle display digital form filler tool

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. Visit http://vote-gov.lndo.site/admin/content/block/23 and see the new fields
  2. Confirm the content is in collapsible groups now (requested by Susan)
  3. Confirm the help text is applied to various fields in the form
  4. Translate the block and make sure the new fields are translatable
  5. Visit http://vote-gov.lndo.site/node/26/edit
  6. Confirm the content in the State Display Content tab is collapsible
  7. Confirm the help text is applied to various fields in the form
  8. Translate the state and make sure experience is the same

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada marked this pull request as ready for review November 13, 2024 00:35
@daniel-crowder daniel-crowder merged commit 9479bd4 into dev Nov 13, 2024
2 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2961-helptext branch December 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants