Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2652 Update state page strings Korean #1115

Merged
merged 1 commit into from
Nov 18, 2024
Merged

VOTE-2652 Update state page strings Korean #1115

merged 1 commit into from
Nov 18, 2024

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Nov 15, 2024 •
edited by clmedders
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2652

Description

Update hardcoded strings for Korean state page.

Deployment and testing

Post-deploy steps

  1. lando retune
  2. If necessary - lando import-translations

QA/Testing instructions

  1. View a state page in Korean and confirm the hardcoded strings have been updated.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders merged commit 7889212 into dev Nov 18, 2024
2 checks passed
@clmedders clmedders deleted the feature/VOTE-2652/update-ko-strings branch November 18, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clmedders clmedders clmedders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamiraMSadat @clmedders