Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-3167 Update NVRF to v0.21.0 #1139

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Nov 27, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-3167

Description

Update the NVRF to v0.21.0

Deployment and testing

Post-deploy steps

  1. lando retune
  2. Login to the CMS and go to https://cms-stage.vote.gov/es/taxonomy/term/2/edit?destination=/es/admin/structure/taxonomy/manage/nvrf_field/overview
  3. Edit the title values so they do not include a period (Mr , Mrs etc.)
  4. Visit https://cms-stage.vote.gov/es/taxonomy/term/11/edit?destination=/es/admin/structure/taxonomy/manage/nvrf_field/overview and repeat step 3

QA/Testing instructions

  1. Visit a state page and switch the language to Spanish.
  2. Click on the NVRF button and fill out all fields (both required and not required).
  3. Confirm all data is mapped correctly to the Spanish PDF.
  4. Confirm the app is using the latest Spanish PDF (you will notice the dropdowns have been replaced with radio buttons as seen below)
    image
  5. Repeat steps 1-3 for the English app and PDF

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada changed the title VITE-3167 Update NVRF to v0.21.0 VOTE-3167 Update NVRF to v0.21.0 Dec 2, 2024
@rayestrada rayestrada merged commit a44a92d into dev Dec 2, 2024
2 checks passed
@rayestrada rayestrada deleted the feature/VOTE-3167/update-nvrf-v0.21.0 branch December 3, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants