Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-464 Initialize redesign votegov theme #422

Merged
merged 25 commits into from
Nov 27, 2023

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Oct 27, 2023

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-464

Description

This PR installs and enables a new theme based on the bixal_uswds theme. This work will be combined with the header and footer so that when we switch over users will be able navigate through the site.

Deployment and testing

Post-deploy

  1. cd into the votegov theme
  2. run nvm use to load node 20
  3. run npm i
  4. run npm run build
  5. run lando retune

QA/Test

  1. Visit http://vote-gov.lndo.site/ and confirm you see a blank theme that needs lots of work

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
mlloydbixal
mlloydbixal previously approved these changes Nov 3, 2023
@mlloydbixal mlloydbixal force-pushed the integration/resdesign-scaffolding branch from 1c2fc32 to 2662114 Compare November 3, 2023 15:53
clmedders
clmedders previously approved these changes Nov 3, 2023
Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! well bad but the good bad!

@mlloydbixal
Copy link
Contributor

Initialization work looks good and is approved

@rayestrada rayestrada marked this pull request as ready for review November 22, 2023 00:13
@rayestrada rayestrada merged commit 0150269 into dev Nov 27, 2023
@rayestrada rayestrada deleted the integration/resdesign-scaffolding branch January 30, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants