Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme foundation #501

Merged
merged 4 commits into from
Jan 13, 2024
Merged

Theme foundation #501

merged 4 commits into from
Jan 13, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Jan 10, 2024

Jira ticket

Insert a link to the Jira ticket (e.g VOTE-XXX).

Description

Insert a brief summary of the changes included in this PR and any additional information or context which may help the reviewer.

Deployment and testing

Pre-deploy

  1. Log into the site and set Claro as the default theme http://vote-gov.lndo.site/admin/appearance
  2. Uninstall Bixal USWDS Base theme http://vote-gov.lndo.site/admin/appearance
  3. Uninstall the Vote.gov USWDS Theme (version 3.2.0) http://vote-gov.lndo.site/admin/appearance

Post-deploy

  1. cd into the votegov theme directory and run npm run build
  2. run lando retune

QA/Test

  1. Insert steps to test and confirm the result meets the "definition of done".

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada changed the title Integration/theme foundation Theme foundation Jan 10, 2024
@rayestrada rayestrada marked this pull request as ready for review January 13, 2024 00:49
@rayestrada rayestrada merged commit 55e1bf5 into dev Jan 13, 2024
3 checks passed
@rayestrada rayestrada deleted the integration/theme-foundation branch January 30, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant