Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/vote 888/general election date 2024 #599

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Feature/vote 888/general election date 2024 #599

merged 3 commits into from
Mar 11, 2024

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Mar 7, 2024 •
edited by rayestrada
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-888

Description

Add the election date variable corresponding to the deadlines.
Add the translations for the election date phrase

Deployment and testing

Pre-deploy

  1. lando retune

Post-deploy

  1. You might have to run lando import-translations

QA/Test

  1. Visit a state page and confirm the date and phrase display above the deadlines.
  2. Confirm the translations for the phrase and date are correct

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@SamiraMSadat SamiraMSadat requested a review from rayestrada March 7, 2024 16:28
@rayestrada rayestrada merged commit c09c8e5 into dev Mar 11, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-888/general-election-date-2024 branch April 23, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayestrada rayestrada rayestrada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamiraMSadat @rayestrada