Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-909 add submenu parent link in dropdown #609

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Mar 13, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-909

Description

Add parent link inside header menu dropdown

Deployment and testing

Post-deploy

  1. run lando drush cr

QA/Test

  1. log in and visit http://vote-gov.lndo.site/
  2. toggle the dropdown for "Guide to Voting" and confirm there is a clickable link to "Guide to Voting" inside the dropdown.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada requested a review from clmedders March 13, 2024 23:42
Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-03-15 at 12 14 50 PM
im seeing the guide to voting 3 times they are working but didnt know for sure what that expected result is

@clmedders clmedders self-requested a review March 21, 2024 19:13
@rayestrada rayestrada merged commit d1136af into dev Mar 21, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-909-parent-menu-link branch April 23, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants