Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-937: style refinements on voter guides #620

Merged
merged 6 commits into from
Mar 25, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Mar 20, 2024

Jira ticket

Insert a link to the Jira ticket (e.g VOTE-XXX).

Description

Refines styles for voter guide pages and adds image background to the headings

Deployment and testing

Pre-deploy

  1. Insert any required steps to take before merging and running post-deploy.

Post-deploy

  1. Insert any required steps to take before beginning test.

QA/Test

  1. npm run build
  2. compare voter guide pages to figma files and ticket notes

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal requested a review from rayestrada March 20, 2024 21:34
@rayestrada rayestrada merged commit 5c45df9 into dev Mar 25, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-937/refine-voter-guide branch April 23, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants