Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-981 add views_data export module #621

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Mar 20, 2024

Add ability to export NVRF reports as csv

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-981

Description

Add ability to download NVRF data reports as csvs.

Deployment and testing

Post-deploy

  1. run lando retune

QA/Test

  1. visit http://vote-gov.lndo.site/admin/nvrf-fields/export and make sure that it exports a csv of data
  2. visit http://vote-gov.lndo.site/admin/nvrf-state-report/export and make sure that it exports a csv of data
  3. visit http://vote-gov.lndo.site/admin/nvrf-state-report/fields/export and make sure that it exports a csv of data

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

Add ability to export NVRF reports as csv
@rayestrada rayestrada marked this pull request as ready for review March 20, 2024 23:33
@daniel-crowder daniel-crowder self-assigned this Mar 21, 2024
@daniel-crowder
Copy link
Contributor

The CSVs are being generated successfully.
The only question that I have regarding http://vote-gov.lndo.site/admin/nvrf-state-report/fields/export is weather all the fields are supposed to be together in one column. This will probably be tricky given how those fields are built out.

Screenshot 2024-03-21 at 12 58 49 PM n.

Copy link
Contributor

@daniel-crowder daniel-crowder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment about one of the exports and if the output is acceptable as is or not. If so we can approve it.

@rayestrada
Copy link
Contributor Author

The CSVs are being generated successfully. The only question that I have regarding http://vote-gov.lndo.site/admin/nvrf-state-report/fields/export is weather all the fields are supposed to be together in one column. This will probably be tricky given how those fields are built out.

Screenshot 2024-03-21 at 12 58 49 PM n.

Yep I realize this is not ideal. Let's wait to hear from Susan how she would like the data to be organized before making changes.

@rayestrada rayestrada merged commit a5b1c96 into dev Mar 25, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-981-report-csv-export branch April 23, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants