Feature/VOTE-965: Tome generation improvements #623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
VOTE-965
Description
Update static site generation script to clean up unwanted files, improve processing, and replace absolute asset links for uploaded files.
Deployment and testing
Pre-deploy
n/a
Post-deploy
QA/Test
Local Testing:
lando retune
to rebuild site locally.lando static
to build your static site locally.cd html
from the project root.find . -type d -name "node" -print -exec rm -rf {} +
find . -type f -exec grep -l 'http[s]*://[^/]\+/s3/files' {} \;
to confirm that the filename is listed in the terminal.find . -type f -exec grep -l 'http[s]*://[^/]\+/s3/files' {} \; -exec sed -i 's#http[s]*://[^/]\+/s3/files#/s3/files#g' {} +
Cloud Environment Testing:
-- No missing assets are reported or CORS alerts (images, fonts, etc.)
-- Inspect the hero image and confirm that the url is a relative url
-- Using the 'Sources' tab in the browser inspection tool, locate an aggregated css file /sites/default/files/css/css_.... and confirm that asset paths are relative urls (ie. background-image: url(/themes/...))
Checklist for the Developer
Checklist for the Peer Reviewers