Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-949: Style refinements to CTA text + image #624

Merged
merged 26 commits into from
Mar 25, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Mar 22, 2024

Jira ticket

VOTE-949

Description

Adds breakpoints matching this figma reference:
https://www.figma.com/file/E70piAGXmi4UzrHs0A90cm/Vote.gov-Redesign-2024-(Master)?node-id=4697%3A2991&mode=dev

Deployment and testing

Pre-deploy

  1. Insert any required steps to take before merging and running post-deploy.

Post-deploy

  1. Insert any required steps to take before beginning test.

QA/Test

  1. lando retune
  2. npm run build
  3. make sure there is a CTA block with content in it
  4. check styling against figma file and test with different content lengths

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

rayestrada and others added 23 commits December 5, 2023 08:28
Sprint 47: Release candidate to STAGE
MId-sprint 48: HOTFIX release
VOTE-570 add section alert field to nvrf field taxonomy
Sprint 48: release candidate to STAGE
Sprint 49: release candidate for STAGE
Sprint 50: release candidate to STAGE
Sprint 51: Release Candidate to STAGE
Sprint 52: release candidate to STAGE
VOTE-541: remove taxonomy pages from static site after generation
HOTFIX for missing hmn configuration
HOTFIX clean out unused config
Sprint 53: release candidate to STAGE
Sprint 54: release candidate to STAGE
@mlloydbixal mlloydbixal requested a review from rayestrada March 22, 2024 18:43
@rayestrada rayestrada merged commit b543f39 into dev Mar 25, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-949/refine-cta branch April 23, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants