Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote-942: Hero Refinements #629

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Vote-942: Hero Refinements #629

merged 5 commits into from
Mar 25, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Mar 25, 2024 •
edited by rayestrada
Loading

Jira ticket

Vote-942

Description

Updating the Hero section for image refinements and some desktop refinement. Also updating the config to help with image size

Deployment and testing

Pre-deploy

  1. Run lando retune

Post-deploy

n/a

QA/Test

  1. Pull down branch and run lando retune and lando drush uli and log in. In the ticket there will be a sample image that was used from local work and sent from the design team.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders requested a review from rayestrada March 25, 2024 17:27
@clmedders clmedders marked this pull request as ready for review March 25, 2024 17:27
@rayestrada rayestrada merged commit c2de264 into dev Mar 25, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-942-hero-refinments branch April 23, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayestrada rayestrada rayestrada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clmedders @rayestrada