Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-1001 Add global touchpoints feedback survey #632

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Mar 28, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-1001

Description

This task added a button in the bottom right for a touchpoints survey. On mobile it is at the bottom of the scrollable page. It should trigger a touchpoints form dialog when selected.

Deployment and testing

Post-deploy

  1. cd into votegov theme and run npm run build
  2. run lando drush cr

QA/Test

  1. Visit http://vote-gov.lndo.site/ and confirm a touchpoint button displays on bottom right on mobile.
  2. Click the button and make sure the form dialog displays.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada marked this pull request as ready for review March 28, 2024 17:37
@rayestrada rayestrada requested a review from clmedders March 28, 2024 17:37
@clmedders
Copy link
Contributor

Screenshot 2024-03-28 at 4 20 55 PM saw this when i submitted

@clmedders
Copy link
Contributor

Also, there were several pages, about page, state registration, and state pages that the form was not showing after hitting the button.

Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments above

@rayestrada
Copy link
Contributor Author

We think the issues are just related to caching and are resolved on refresh. The Form is not expected to work on any host other than vote.gov.

@rayestrada rayestrada merged commit a12a3da into dev Mar 29, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-1001-touchpoints-survey branch April 23, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants