Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-992: Remove a comma from state page template #640

Merged
merged 1 commit into from
Apr 3, 2024
Merged

VOTE-992: Remove a comma from state page template #640

merged 1 commit into from
Apr 3, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Apr 1, 2024 •
edited
Loading

Jira ticket

VOTE-992

Description

Removes unnecessary comma from translation files and state page template.

Deployment and testing

Pre-deploy

  1. lando retune
  2. Visit a state page to confirm comma is removed.
  3. Other translations should still translate the same.

Post-deploy

  1. Insert any required steps to take before beginning test.

QA/Test

  1. Insert steps to test and confirm the result meets the "definition of done".

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal requested a review from clmedders April 2, 2024 16:41
clmedders
clmedders requested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like English is missing the update... unless that is expected?

Also, the Pr is still in draft!

@mlloydbixal mlloydbixal marked this pull request as ready for review April 3, 2024 12:54
@clmedders clmedders merged commit aab38f4 into dev Apr 3, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-992/rm-comma branch April 23, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clmedders clmedders clmedders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlloydbixal @clmedders