Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-1027: Update width for NVRF button at mobile #645

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Apr 5, 2024

Jira ticket

Vote-1027

Description

Setting max-width at the mobile large break point to help the drop-down and button maintain the same width in in mobile view.

Deployment and testing

Pre-deploy

n/a

Post-deploy

n/a

QA/Test

  1. Pull down the branch and cd into the votegov dir and run npm run build
  2. Visit /register/alabama and scroll to the download nvrf button and adjust your screen size.. as the screen gets larger it should keep the same width until the mobile large breakpoint at 480

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders changed the title Vote-1027: update to mobile nvrf button Vote-1027: Update width for NVRF button at mobile Apr 5, 2024
@clmedders clmedders marked this pull request as ready for review April 8, 2024 13:40
@daniel-crowder daniel-crowder merged commit b7bf967 into dev Apr 8, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-1027-nvrf-mobile-btn branch April 23, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants